Skip to content

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model#2143

Open
NarrowsProjects wants to merge 6 commits intofeature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-urlfrom
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel
Open

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model#2143
NarrowsProjects wants to merge 6 commits intofeature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-urlfrom
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 23, 2026 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Setting filters will now display them in the url

Notable changes for developers:

  • All filters now have a normalized setter that will set the values of the filters based on the output of the normalize getter in query parameter form.

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 23, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 23, 2026
@NarrowsProjects NarrowsProjects changed the base branch from main to feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url April 23, 2026 15:10
@NarrowsProjects NarrowsProjects changed the title Impov/o2 b 1555/add normalize setter functions to all classes that extend filter model and selection model [O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.89%. Comparing base (ae6c287) to head (49ed030).

Files with missing lines Patch % Lines
...blic/components/common/selection/SelectionModel.js 0.00% 17 Missing ⚠️
...onents/Filters/RunsFilter/MagnetsFilteringModel.js 0.00% 9 Missing ⚠️
.../Filters/RunsFilter/MultiCompositionFilterModel.js 0.00% 5 Missing ⚠️
.../Filters/common/filters/ProcessedTextInputModel.js 0.00% 5 Missing ⚠️
...ponents/Filters/RunsFilter/EorReasonFilterModel.js 0.00% 4 Missing ⚠️
...s/common/filters/NumericalComparisonFilterModel.js 0.00% 4 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 4 Missing ⚠️
...ponents/Filters/RunsFilter/DetectorsFilterModel.js 0.00% 3 Missing ⚠️
...ic/components/Filters/RunsFilter/GaqFilterModel.js 0.00% 3 Missing ⚠️
...nts/Filters/RunsFilter/RunDefinitionFilterModel.js 0.00% 3 Missing ⚠️
... and 14 more
Additional details and impacted files 
@@                                                     Coverage Diff                                                      @@
##           feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url    #2143      +/-   ##
============================================================================================================================
- Coverage                                                                                     45.92%   45.89%   -0.04%     
============================================================================================================================
  Files                                                                                          1037     1036       -1     
  Lines                                                                                         17153    17167      +14     
  Branches                                                                                       3116     3122       +6     
============================================================================================================================
  Hits                                                                                           7878     7878              
- Misses                                                                                         9275     9289      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 11 times, most recently from e540f27 to edb626f Compare April 27, 2026 07:04
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url branch from 4a30d27 to ae6c287 Compare April 27, 2026 07:17
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch from edb626f to 88cc4f4 Compare April 27, 2026 07:24
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch from 88cc4f4 to 49ed030 Compare April 27, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta Awaiting requested review from graduta graduta is a code owner

Assignees

@NarrowsProjects NarrowsProjects

Labels

frontend javascript Pull requests that update Javascript code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NarrowsProjects