feat(bigtable): sweep stale accelerator daemon tempdirs at startup - #16
Open
mutianf wants to merge 3 commits into
Open
feat(bigtable): sweep stale accelerator daemon tempdirs at startup#16mutianf wants to merge 3 commits into
mutianf wants to merge 3 commits into
Conversation
mutianf
force-pushed
the
accel-14-user-agent-and-stress-selfmanage
branch
from
August 12, 2026 14:07
7d34ca7 to
280aef6
Compare
mutianf
force-pushed
the
accel-15-stale-tempdir-sweep
branch
from
August 12, 2026 14:07
cd69e5e to
e030425
Compare
mutianf
force-pushed
the
accel-14-user-agent-and-stress-selfmanage
branch
from
August 12, 2026 18:56
280aef6 to
650d65e
Compare
mutianf
force-pushed
the
accel-15-stale-tempdir-sweep
branch
from
August 12, 2026 18:56
e030425 to
a282495
Compare
mutianf
force-pushed
the
accel-14-user-agent-and-stress-selfmanage
branch
from
August 12, 2026 19:04
650d65e to
41099ef
Compare
mutianf
force-pushed
the
accel-15-stale-tempdir-sweep
branch
from
August 12, 2026 19:04
a282495 to
ac414ce
Compare
mutianf
force-pushed
the
accel-14-user-agent-and-stress-selfmanage
branch
from
August 14, 2026 21:02
41099ef to
4a98c76
Compare
mutianf
force-pushed
the
accel-15-stale-tempdir-sweep
branch
2 times, most recently
from
August 19, 2026 14:47
3ef4b2b to
fce05b2
Compare
mutianf
force-pushed
the
accel-14-user-agent-and-stress-selfmanage
branch
2 times, most recently
from
August 24, 2026 16:38
6f37ecc to
65c275f
Compare
Change-Id: Ib373fb96c7f93160a118b5cebeaa4b1328f26886
… avoid contract-acceptable retry-straggler race Change-Id: Ifb8d19946e0e53e4b61610094d79df2d0672eae0
…r fuzz/stress (mirror of delete-after-write) Change-Id: I7c491e14ac0fb35b7bc8634bb7f9896772669e69
mutianf
force-pushed
the
accel-15-stale-tempdir-sweep
branch
from
August 24, 2026 16:42
75fcfd2 to
9949d5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top of the accelerator stacked-PR chain (on top of accel-14).
What
At
AcceleratorDaemon.start(), before minting a new tempdir, sweep leftoverbt-accel-*tempdirs from daemons that crashed without runningclose().Why
A daemon killed without a clean shutdown (SIGKILL, OOM, host reboot) leaves its
tempdir — socket,
identity.json,daemon.log— behind in$TMPDIR. Over along-lived host these accumulate. The sweep reclaims them at the next client
startup.
How it decides a dir is stale
Keyed off the
daemon.logmarker inside eachbt-accel-*dir (not just the dirprefix), a dir is removed only when all hold:
daemon.log(so it's really one of ours, mid-lifecycle),sockis not connectable (a live daemon owns it — never touch it).Best-effort: any
OSErroron a given dir skips it silently.Tests
TestSweepStaleTempdirs(5 tests): removes a stale dir, keeps a young dir,ignores a dir without the log marker, keeps a dir with a live socket, and
confirms
start()invokes the sweep. Full accelerator unit suite green.