Repository navigation
Update mlp.py - #5
Seyyidosman wants to merge 1 commit into
Conversation
In the _sigmoid_derivative methode. There was a x * (1 - x) but the derivative of sigmoid function should be sigmoid(x) * (1- sigmoid(x))
|
Hi @Seyyidosman, thank you very much for your interest in the repository and for looking so closely at the mathematical implementation! I sincerely appreciate your patience during this time. After reviewing the code, I have decided to decline this PR to maintain the current implementation. The proposed change is not really necessary, as the current code uses a standard optimization where the derivative is calculated using the already-computed activations.
I really appreciate the curiosity and the time you took to verify the formulas—it’s exactly the kind of attention to detail we love to see in the TSOAI community! I'll be closing this PR to keep the code aligned with the logic taught in the videos. |
In the _sigmoid_derivative methode. There was a x * (1 - x) but the derivative of sigmoid function should be sigmoid(x) * (1- sigmoid(x))