Skip to content

Fix doc links - #999

Merged
jcrist merged 2 commits into
mainfrom
fix-doc-links
Apr 8, 2026
Merged

jcrist merged 2 commits into
mainfrom
fix-doc-links

Conversation

@jcrist

@jcrist jcrist commented Apr 8, 2026

Copy link
Copy Markdown
Member

No description provided.

jcrist added 2 commits April 8, 2026 12:10
just builds are broken on windows arm64. Really all this profiling in CI
should probably be dropped; CI doesn't provide a stable run environment,
it's just wasting cycles.
@jcrist
jcrist merged commit ab0df07 into main Apr 8, 2026
21 checks passed
@jcrist
jcrist deleted the fix-doc-links branch April 8, 2026 17:24
@ofek

ofek commented Apr 8, 2026

Copy link
Copy Markdown
Member

Why did we drop Windows ARM? It's increasingly popular and I was hoping to upgrade my personal machine this year to such a device.

@jcrist

jcrist commented Apr 8, 2026

Copy link
Copy Markdown
Member Author

The profiling build was failing, and I didn't want to bother debugging 🙃.

IMO profiling this way in CI is pretty meaningless anyway. The runs are too noisy to get meaningful results. Something like codspeed.io may be more useful, but IMO unless we can rely on the results then it's not worth it.

@ofek

ofek commented Apr 8, 2026 •

Copy link
Copy Markdown
Member

All good, I was just confused. We can add it back and fill in the artifacts for the current release. Nevermind 🙂

Profiling this way is better than nothing though, which is why I added it! While there is definitely noise it allowed me to catch regressions and locally compare different implementations of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants