Repository navigation
Fix JSON schema metadata for dictionary keys - #1159
Merged
Merged
Conversation
fallenmi
marked this pull request as ready for review
August 25, 2026 12:41
Siyet
added this pull request to the merge queue
Sep 13, 2026
|
Thanks for the fix, @fallenmi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #866.
Dictionary key annotations with JSON Schema metadata are represented internally as Metadata wrappers. The dictionary schema branch only recognized a bare StrType, so adding metadata such as title caused both that metadata and string constraints to disappear from propertyNames.
This change verifies that the wrapped key is a string, generates propertyNames from the original annotated key schema, and removes the redundant string type. Existing behavior for plain and constraint-only string keys is preserved.
Validation:
AI assistance disclosure: OpenAI Codex helped investigate, implement, and test this change. The account owner authorized publication; upstream workflows still require maintainer approval before they can run.