Repository navigation
Fix dec_hook exception type in json.decode docstring - #1127
Merged
provinzkraut merged 1 commit intoJul 20, 2026
Merged
Conversation
Fixes msgspec#774. json.decode was the only dec_hook docstring saying to raise a TypeError for an unsupported type; json.Decoder, msgpack.decode, msgpack.Decoder, and convert all say NotImplementedError, which jcrist confirmed in msgspec#774 is the intended contract (TypeError/ValueError are for bad values). The changelog entry points at the issue since there's no PR number yet; it can reference the PR instead once one exists. Disclosure: I used AI assistance (Claude) to draft this change and reviewed the result.
provinzkraut
added this pull request to the merge queue
Jul 20, 2026
provinzkraut
removed this pull request from the merge queue due to a manual request
Jul 20, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
provinzkraut
added this pull request to the merge queue
Jul 20, 2026
Brohammad
pushed a commit
to Brohammad/msgspec
that referenced
this pull request
Sep 4, 2026
The 0.21.1 to 0.22.0 changelog batch (msgspec#1112) landed on 2026-07-03. Four user-visible changes merged between then and the 0.22.0 release on 2026-08-11 never got an entry: - msgspec#700, overloads on the `Meta` stub, so type checkers reject mixing `gt` with `ge` and `lt` with `le` - msgspec#1028, `null` placed last in the `anyOf` generated for optional unions - msgspec#1114, `__struct_encode_fields__` added to `src/msgspec/__init__.pyi` (its companion msgspec#813 only touched `tests/typing`, so it needs no entry of its own) - msgspec#1118, `json.encode` raising `TypeError` for a `dict` keyed by a plain `str`-valued `enum.Enum` I went over every PR merged in that window. The rest need no entry: msgspec#813 and msgspec#1117 are tests only, msgspec#1121 fixes an unreleased regression from msgspec#1028, msgspec#1145 is an unused variable under free-threaded builds, and msgspec#1146 and msgspec#1148 are CI and tooling. msgspec#1127, msgspec#1135 and msgspec#1080 already have entries. Docs build clean with `--fail-on-warning`. Note for whoever retries the release: the section is still headed `Version 0.22.0 (2026-08-11)`, and that date will need updating, since the tag was deleted after the upload failed. Refs msgspec#1134. Co-authored-by: Siyet <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #774.
json.decodewas the onlydec_hookdocstring telling users to raise aTypeErrorfor an unsupported type.json.Decoder,msgpack.decode,msgpack.Decoder, andconvertall sayNotImplementedError, which is theintended contract you confirmed in #774 (
TypeError/ValueErrorare for avalue that doesn't match the type). This changes the one line to match.
Grepped the rest of the tree for the wording and this docstring was the only
copy, so there's nothing to fix in the docs or stubs. Added an
## Unreleasedchangelog entry. I pointed it at the issue with
{issue}774`` since there wasno PR number when I wrote it; happy to swap it to
{pr}with this PR's number.Disclosure: I used AI assistance (Claude) to draft this change and reviewed the
result.