Repository navigation
Fix CodSpeed path filters - #1091
Merged
Merged
Conversation
ofek
marked this pull request as ready for review
June 20, 2026 20:05
Member
Author
|
@provinzkraut I noticed this because I clicked the button to update the branch of #1005 so that we could see the new micro benchmarks but they didn't run. |
Member
|
Thanks for the patch @ofek! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
#1085 added path filters to avoid running CodSpeed on unrelated changes, but patterns like
src/*,tests/prof/*, andbenchmarksonly match direct root-level paths. They do not match files such assrc/msgspec/structs.pyortests/prof/perf/test_structs.py, so performance-related PRs like #1005 can skip the benchmark workflow entirely.Validation