Repository navigation
Support the PyEmscripten platform - #1083
Conversation
Merging this PR will improve performance by 2.68%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
320368f to
3dbb4e4
Compare
a5abc6b to
355f586
Compare
|
@msgspec/committers This is ready for review! I was anticipating having to exclude these builds on PRs but they are actually now the fastest platform job. Should we wait to build 3.15? |
| return lk->table[index]; | ||
| /* Compute the dense-table index in 64-bit space so large offsets | ||
| * cannot wrap through Py_ssize_t on 32-bit builds. */ | ||
| if (key >= lk->offset) { |
There was a problem hiding this comment.
Probably a bit paranoid, but this does kinda sit in a hot path, so I'd be curious to see the impact this has on pure int decoding when measured with #1087
There was a problem hiding this comment.
Let's merge that one first and then I'll rebase.
f04018c to
37c8324
Compare
|
@provinzkraut I rebased to trigger tests on the larger runners. Should we merge? |
I'm fine with it. The perf tests seem to be quite useless at the moment though, even with the macro-runners. I've re-opened CodSpeedHQ/codspeed#409 🤷 |
Resolves #1089
Notes
RangeError: Maximum call stack size exceededwhen combiningpartialwith infinite recursion pyodide/pyodide#5959References
AI use
I collaborated with GPT-5.5 on Extra High for the following: