Add support for typing.ByteString/collections.abc.ByteString #52

Activity

1. jakirkham commented on Sep 9, 2021

   

   jakirkham

   on Sep 9, 2021

   More actions

   This would be great and supporting both makes sense.

   It's worth noting the docs say...

   Deprecated since version 3.9: collections.abc.ByteString now supports []. See PEP 585 and Generic Alias Type.
2. jakirkham commented on Sep 9, 2021

   

   jakirkham

   on Sep 9, 2021

   More actions

   Also interesting in collections.abc.ByteString they mention memoryviews are supported, but that doesn't appear to be the case.

   import collections.abc
   import typing
   
   print(isinstance(memoryview(bytes()), collections.abc.ByteString))
   print(isinstance(memoryview(bytes()), typing.ByteString))

   False
   False
   
3. jcrist commented on Sep 9, 2021

   

   jcrist

   on Sep 9, 2021

   MemberAuthor

   More actions

   Oh, interesting. That certainly seems like a bug (at least in the documentation). mypy does count memoryviews here. You can make the runtime check work by calling

   collections.abc.ByteString.register(memoryview)
   

   but that applies a global change that may break things elsewhere (but is probably harmless).

   👍React with 👍1Reacted by jakirkham
4. jakirkham commented on Sep 9, 2021

   

   jakirkham

   on Sep 9, 2021

   More actions

   Good point

   This upstream issue ( https://bugs.python.org/issue33864 ) looks related. Seems like there is confusion as to if/how this should be included

   Independently does annotating with memoryview work currently?
5. jcrist

   closed this as completedin #55on Nov 1, 2021
6. sobolevn

   added a commit that references this issue on Oct 12, 2026

   Fix `Meta(pattern=..)` memory leak / corruption (msgspec#1256)

   ...

   4f7363d