Added is_map function to check is array map or plain array - #6
Closed
bobrik wants to merge 4 commits into
Closed
Conversation
This is copy of msgpack/msgpack#111 because of msgpack-php split. Fixes msgpack/msgpack#87 (bug with incorrect packing of mixed arrays). Patch is pretty straightforward.
Member
|
and, a test script is needed, thanks :) |
Member
|
if you don't want to make a test script, then I can do it. what do you think? thanks |
Author
|
It would be great! You may find test data here: msgpack/msgpack#87 |
laruence
added a commit
that referenced
this pull request
Sep 26, 2012
Member
|
hey, after a deep look, I found this will introduce a performance issue, and the fix will alter the array internal pointer, I got another fix, e8d25b0 thanks |
ghost
assigned
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is copy of msgpack/msgpack#111 because of msgpack-php split.
Fixes msgpack/msgpack#87 (bug with incorrect packing of mixed arrays).
Patch is pretty straightforward.