Hey, Anatoliy, could you explain a little more what the bug is? :)

thanks

Hi Hui,

msgpack has references to the session extension. When php compiled with "--disable-all --enable-cli --enable-msgpack=shared" a link error is to see. Not able yet to compile with the dev pack on win as there's a dependency.

A better solution might be to add something like --enable-msgpack-session , but this would require to isolate the appropriate places in the code using HAVE_PHP_SESSION macros. I'd see that rather not necessary as session is one of the mandatory core extensions. Of course there are chances someone excludes the session ext in a custom build, but normally session is statically compiled (at least on win) into PHP.

Cheers

Anatoliy

thanks, but thinking of the situation that seesion is built as a share extension.

I'd say, maybe we should disable session serializer handler, if the session is not enabled. :)

thanks

Yep, that's what I've meant above - if session ext isn't compiled statically or isn't loaded, currently there's clearly a fail in msgpack. However the patch I've sent will suffice in 99.8% of the cases under windows as session is statically compiled in released php binaries.

The session handler should obviously be disabled at the run time if the session ext isn't available. But that's just another question - compile vs. run time. IMHO it should be always compiled with the session support as on windows most users just use the precompiled dlls.

Cheers )

fixed in 21b22bf

thanks