Skip to content

Display float/double values in an appropriate format #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komamitsu merged 1 commit into from
Nov 14, 2014
Merged

Display float/double values in an appropriate format #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion msgpack-core/src/main/java/org/msgpack/value/holder/FloatHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,14 @@ public int hashCode() {

@Override
public String toString() {
return Double.toString(value);
switch(tpe) {
case FLOAT:
return Float.toString((float) value);
case DOUBLE:
return Double.toString(value);
default:
throw new IllegalStateException("cannto reach here");
}
}


Expand Down
26 changes: 26 additions & 0 deletions msgpack-core/src/test/scala/org/msgpack/value/holder/FloatHolderTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package org.msgpack.value.holder

import org.msgpack.core.MessagePackSpec

/**
*
*/
class FloatHolderTest extends MessagePackSpec {

"FloatHolder" should {

"display value in an appropriate format" in {

val h = new FloatHolder
val f = 0.1341f
h.setFloat(f)
h.toString shouldBe java.lang.Float.toString(f)

val d = 0.1341341344
h.setDouble(d)
h.toString shouldBe java.lang.Double.toString(d)
}

}

}