Log checks messages in heartbeat view - #86
Merged
Conversation
leplatrem
force-pushed
the
log-errors-heartbeat
branch
from
November 7, 2023 16:22
783d6b1 to
d9c6040
Compare
This implements ``monitoring-heartbeat-error`` of our https://mozilla.github.io/syseng-pod/quality-standards/
leplatrem
force-pushed
the
log-errors-heartbeat
branch
from
November 8, 2023 14:40
d9c6040 to
b962bb0
Compare
grahamalama
previously approved these changes
Nov 13, 2023
grahamalama
reviewed
Nov 13, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 97.80% 97.84% +0.04%
==========================================
Files 18 18
Lines 591 602 +11
Branches 85 88 +3
==========================================
+ Hits 578 589 +11
Misses 9 9
Partials 4 4 ☔ View full report in Codecov by Sentry. |
grahamalama
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
monitoring-heartbeat-errorof our https://mozilla.github.io/syseng-pod/quality-standards/