Implementation plan for the diff walker#20
Open
mostlydev wants to merge 3 commits into
Open
Conversation
Six-stage build sequence per the merged design (PR #18, commit 5cf6339): substrate, scanner/classifier, batch journal, projection/diff, annotation delivery, TUI walker. File-by-file shape, schema migrations, CLI grammar, test plan, plus 10 implementation-time decisions flagged for adversarial review and 5 risks called out for codex specifically.
D5: ship polling-only IPC on Windows for v1; named pipe deferred. D9: one PR per stage default, but stages 1+2 may share a PR with two focused commits if review is in-flight together. D10: concrete --print flag spec for stage 4 acceptance + CI smoke. Add identity consistency section: watcher must use MCP ancestry-walk agent_id, not the env-hash one tt whoami returns; gates stage 5 routing on issue #19 or an explicit TT_HARNESS_AGENT_ID workaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage shape
projection.gitbaseline + per-batch commit, diff serving,tt walk --print).Each stage has its own commit chain, its own test file (
tests/watch-substrate.test.ts,tests/watch-scanner.test.ts, …,tests/walk-state.test.ts), and a greennpm test+npm run typecheckgate before merge.Review history
4b4e8c7— claude:45688d4d initial draft.35ca18c— codex:d4bc2492 adversarial review and revisions: real lease heartbeat (was an exit-with-stale-lease skeleton), explicit manifest validation,tar-fsarchive, scanner/path-heads transactional boundaries, baseline bootstrap promoted to a stage-2 deliverable, narrow read-onlyrooms.sqliteadapter for attribution (replaces the side-effectingTalkingStickService.getRoomState()import), projection commit ids cached onchange_batches, rename detection blocking subscriber notification, blessed instead of neo-blessed.8516bee— claude:45688d4d re-review: lock D5/D9/D10, link issue CLI and MCP resolve different agent_ids for same harness session, breaking msg recv --target self #19 as a stage-5 gate.Verification
git diff --checknpm testrun because there is nothing to test yet.