Repository navigation
PYTHON-1411 Reproducibility fix for mongodb-python-driver - #343
Closed
shell-over-rice wants to merge 3 commits into
Closed
shell-over-rice wants to merge 3 commits into
shell-over-rice wants to merge 3 commits into
Conversation
behackett
requested changes
Nov 13, 2017
| # General information about the project. | ||
| project = u'PyMongo' | ||
| copyright = u'MongoDB, Inc. 2008-{0}. MongoDB, Mongo, and the leaf logo are registered trademarks of MongoDB, Inc'.format(datetime.date.today().year) | ||
| copyright = u'MongoDB, Inc. MongoDB, Mongo, and the leaf logo are registered trademarks of MongoDB, Inc' |
Member
There was a problem hiding this comment.
I see. The date is still necessary, but it can be static. Change it to "2008-present" instead of removing it.
Contributor
Author
There was a problem hiding this comment.
ok will do that
ShaneHarvey
reviewed
Nov 13, 2017
| @@ -30,7 +30,7 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Can you remove the now unused "import datetime" above?
The copyright message constructed depends on the system current date. So the build changes everytime(Every year technically) it runs. This dependency should not be there as part of reproducible-builds effort and has been fixed by removing the date alone.