Skip to content

PYTHON-6083 Latest server binary downloads require private S3 - #3076

Merged
blink1073 merged 1 commit into
mongodb:mainfrom
blink1073:PYTHON-6083
Sep 30, 2026
Merged

blink1073 merged 1 commit into
mongodb:mainfrom
blink1073:PYTHON-6083

Conversation

@blink1073

@blink1073 blink1073 commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

PYTHON-6083

Changes in this PR

Ensure "latest" server binary downloads come from a private S3 bucket by providing AWS credentials (DRIVERS-3628). Evergreen tasks downloading VERSION=latest now assume drivers-test-secrets-role before the download and pass the AWS credentials to the orchestration step.

Test Plan

  • Regenerated the Evergreen configs and verified assume ec2 role is inserted for every latest task and nowhere else.
  • Patch build with one latest task confirms the S3 download succeeds with no FALLBACK: banner.

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)? — N/A, infrastructure
  • Is there test coverage? — N/A, standard tests
  • Is any followup work tracked in a JIRA ticket? — N/A

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Address the redundant role-assumption logic and correct the documented latest-version command.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

This PR updates Evergreen and local server setup so VERSION=latest binaries can be downloaded from private S3 using AWS credentials.

Changes:

  • Adds AWS credential propagation to server orchestration.
  • Adds role assumptions before applicable downloads.
  • Documents latest-version setup and stable defaults.
File Summary Review notes
CONTRIBUTING.md Documents credentials required for latest server downloads. Nit (1 vote): use --version=latest in the documented command.
.evergreen/​scripts/​setup_tests.py Uses a stable server default for OCSP setup. No final comment.
.evergreen/​scripts/​generate_config.py Generates role assumptions and AWS credential propagation. Moderate (3 votes): avoid adding redundant role assumptions to stable-version variants.
.evergreen/​generated_configs/​tasks.yml Regenerated task commands and ordering. No final comment.
.evergreen/​generated_configs/​functions.yml Passes AWS credentials to server setup. No final comment.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .evergreen/scripts/generate_config.py Outdated
The latest/latest-build MongoDB server binaries are now downloaded from
a private S3 bucket (origin-mongodb-server-latest) requiring an AWS
identity, instead of the public downloads.10gen.com hosts.

Every Evergreen task that downloads VERSION=latest now assumes
${aws_test_secrets_role} before the server download, and the AWS
credentials are passed to the server orchestration step. Local runs
default to latest-stable, which needs no credentials.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Role assumption is not inserted before every latest download path, leaving some downloads without required credentials.

Review effort: Lite
Findings: None

Resolved since last review (1)

@blink1073
blink1073 marked this pull request as ready for review September 28, 2026 17:58
@blink1073
blink1073 requested a review from a team as a code owner September 28, 2026 17:58

@aclark4life aclark4life left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blink1073
blink1073 merged commit 916f320 into mongodb:main Sep 30, 2026
93 of 96 checks passed
@blink1073
blink1073 deleted the PYTHON-6083 branch September 30, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants