Repository navigation
Conversation
…) because __slots__() is defined
Member
There was a problem hiding this comment.
I think you should just return self.__id here. There doesn't seem to be any reason to hex encode it first. Without __slots__ pickle would just be serializing __dict__ which wouldn't have a hex encoded version of __id.
Contributor
Author
There was a problem hiding this comment.
yeah, that makes sense. I was mimicking other cases where I've gone back and forth from ObjectId to str (such as URL parameter).
also added unit test for pickling/unpickling ObjectId
Contributor
Author
|
also added a unit test to make sure pickle/unpickle yields original |
Member
There was a problem hiding this comment.
I think you had the right idea here before. Calling validate seems like the correct thing to do.
Member
There was a problem hiding this comment.
On second thought, never mind. It certainly wasn't being called before and just adds overhead. This is fine now. Thanks for the patch!
Member
|
Thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix pickling of ObjectId by defining
__getstate__()and__setstate__()because__slots__()is definedran into this with pymongo 1.10 with exception:
TypeError: a class that defines __slots__ without defining __getstate__ cannot be pickled