Skip to content

JAVA-3085: Add the ability to configure the output format of StrictCharacterStreamJsonWriter - #497

Closed
ZeroErrors wants to merge 1 commit into
mongodb:masterfrom
ZeroErrors:master
Closed

JAVA-3085: Add the ability to configure the output format of StrictCharacterStreamJsonWriter#497
ZeroErrors wants to merge 1 commit into
mongodb:masterfrom
ZeroErrors:master

Conversation

@ZeroErrors

@ZeroErrors ZeroErrors commented Nov 9, 2018

Copy link
Copy Markdown

https://jira.mongodb.org/browse/JAVA-3085

  • Adds the ability to configure StrictCharacterStreamJsonWriter with
  • A PropertySeparator setting to control the spacing between property key's and property value's.
  • A boolean setting for if each array value is to have its own line.
  • Adds new unit tests for the new settings
  • Removes the need to replicate builder settings from StrictCharacterStreamJsonWriterSettings to JsonWriterSettings by using the existing builder.

Misc:

  • Removes unneeded varargs from StrictCharacterStreamJsonWriter.checkPreconditions
  • Removes notNull check from non-nullable boolean argument in StrictCharacterStreamJsonWriter.writeBoolean
$ ./gradlew check
> Task :bson:test
--------------------------------------------------------------------------
Results: SUCCESS (2151 tests, 2146 passed, 0 failed, 5 skipped)
--------------------------------------------------------------------------
> Task :driver-async:test
--------------------------------------------------------------------------
Results: SUCCESS (762 tests, 531 passed, 0 failed, 231 skipped)
--------------------------------------------------------------------------
> Task :driver-core:test
--------------------------------------------------------------------------
Results: SUCCESS (2224 tests, 2173 passed, 0 failed, 51 skipped)
--------------------------------------------------------------------------
> Task :driver-legacy:test
--------------------------------------------------------------------------
Results: SUCCESS (725 tests, 677 passed, 0 failed, 48 skipped)
--------------------------------------------------------------------------
> Task :driver-sync:test
--------------------------------------------------------------------------
Results: SUCCESS (693 tests, 459 passed, 0 failed, 234 skipped)
--------------------------------------------------------------------------

@rozza

rozza commented Dec 4, 2018

Copy link
Copy Markdown
Member

@ZeroErrors many thanks for the pull request and corresponding Jira ticket.

Just to let you know we've currently scheduled this feature for the next release (3.10) and will review in due course.

@ZeroErrors

ZeroErrors commented Jan 13, 2019

Copy link
Copy Markdown
Author

This has been resolved by replacing the current output instead of adding more settings.
See JAVA-3085 for more info.

@ZeroErrors ZeroErrors closed this Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroErrors @rozza