chore: give every coverage pragma a reason (TS6, TS5) - #261
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings coverage exclusions in line with TS5 and TS6.
TS5: dropped
"except ImportError:"from[tool.coverage.report] exclude_also. Noexcept ImportError:block exists in the repo any more (optional-dependency probes live inimport_checker.py), so the entry excluded nothing.TS6 counts: 1 tested / 0 deleted / 2 reasoned.
PyroscopeSpanProcessor.force_flush.TracerProvider.force_flush()calls every processor'sforce_flush, and at the declaredopentelemetry-sdk>=1.28floor the baseSpanProcessor.force_flushreturnsNone, which fails the provider's flush. The new test asserts the provider flush succeeds with the processor attached. The current SDK's base also returnsTrue, so the test only catches a regression at the floor.tracer_injectionelse:branch inlogging_instrument.py. It runs only when opentelemetry is absent, and the test env installs all extras.transient_appintest_litestar_bootstrap.py. It is only a weakref target and is never called.Local checks:
just install,just lint-cipass;just test-ci332 passed, 100 % coverage.