test: adopt the stricter ADR citation check from lite-bootstrap - #120
Merged
Merged
Conversation
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces
tests/test_adr_citations.pywith lite-bootstrap's version, ported onto thepytestconfig.rootpathroot from #119. This is the file consumers fetch frommain(eof-fixer today; 23 open PRs for the rest).Behavioural changes for every consumer:
ADR-NNNNcitations are checked (existence only:docs/adr/NNNN-*.mdmust exist). Previously only thedocs/adr/NNNN-slug.mdpath form was..mdand.tomlare scanned as well as.py.site/(mkdocs output) is skipped.The invariant test is renamed
test_every_adr_citation_in_the_repo_resolves. Two tests added for the new forms.Dry run
The new file was run with
pytest --rootdir=.againstorigin/mainof every repo:docs/agents/domain.md cites ADR-0007. That line is an illustrative example in agent guidance ("Contradicts ADR-0007 (event-sourced orders), but worth reopening because…"); the repo has nodocs/adr/at all. The same text is infastapi-sqlalchemy-templateandlitestar-sqlalchemy-template, which are outside the mechanism (no copy of the test) but fail the same way.So merging this turns that-depends red on its next
adr-checkrun until that example line is reworded (for exampleADR-NNNN), or the rule learns to ignore it. That is the intended pilot signal, not a reason to hold the PR, but the order of merges matters.