docs(standard): let a repo with no runtime dependencies omit the floors job - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI6 requires a
floorsjob that resolves every direct dependency at its declared floor. The conformance audit flaggedmodern-difor lacking one, butmodern-dideclares no runtime dependencies and no extras, so the set the job would resolve is empty.Adding the job anyway is worse than omitting it: with nothing to resolve low, it passes vacuously, and the only thing
--resolution lowest-directwould touch is the unflooreddevgroup, which resolves to each tool's first-ever release and fails for reasons unrelated to what the package ships.This is a clarification, not an exemption: the repo does not depart from the requirement, the requirement has nothing to test.
Changes
modern-di)."Checklist
uv run pytest: 132 passed, 29 skipped)mkdocs build --strictpassesuv build, metadata: not applicable, docs only