Repository navigation
[Server] Stream 2026-07-28 responses on servers that write the body themselves - #691
Merged
chr-hertel merged 3 commits intoNov 8, 2026
Conversation
webagil-kevin
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 8, 2026 16:19
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Stored callbacks retain cancelled handler generators and delay cleanup while the body remains alive, and the ReactPHP loop can resume handlers after a known disconnect.
2 open issues
What changed in this PR
This PR enables event-loop HTTP servers to write streamed 2026-07-28 responses themselves, extending the earlier fiber-scheduler support while retaining the PHP-output path.
Changes:
- Add
CallbackStream::chunks()and move subscription polling delays to stream consumers. - Update Revolt and ReactPHP examples to stream modern responses; handshake-era streams still return
501. - Add streaming and cancellation coverage, and document the new API and polling behavior change.
| File | Description |
|---|---|
tests/Unit/Server/Transport/Http/StatelessResponderTest.php |
Cover SSE output, flushing, pacing, and chunks. |
tests/Unit/Server/Transport/CallbackStreamTest.php |
Cover chunk availability and single-use behavior. |
tests/Unit/Server/Stateless/StatelessProtocolTest.php |
Verify consumer-paced, unlimited subscriptions. |
tests/Unit/Server/Fiber/RealEventLoopTest.php |
Cover streamed notifications and handler cleanup. |
tests/Interop/Server/Http/HttpRevoltTest.php |
Verify subscription streaming over Revolt HTTP. |
tests/Interop/Server/Http/HttpReactPhpTest.php |
Verify subscription streaming over ReactPHP HTTP. |
tests/Interop/Server/Http/HttpInspectorSnapshotTestCase.php |
Add a timed HTTP stream-reading helper. |
src/Server/Transport/Http/StatelessResponder.php |
Share SSE encoding between chunk and PHP-output consumers. |
src/Server/Transport/CallbackStream.php |
Expose single-use response chunks. |
src/Server/Stateless/StatelessProtocol.php |
Delegate subscription pacing to consumers. |
examples/server/revolt/server.php |
Stream chunks through AMPHP with idle pacing. |
examples/server/README.md |
Describe modern streaming support and remaining limits. |
examples/server/reactphp/server.php |
Pump chunks with idle pacing and backpressure handling. |
docs/run/server-builder.md |
Document chunk consumption and event-loop limits. |
CHANGELOG.md |
Record streaming support and the polling behavior break. |
Review effort: Balanced
webagil-kevin
force-pushed
the
stream-sse-frames-under-event-loop
branch
from
November 8, 2026 17:09
bd73dac to
effe802
Compare
chr-hertel
approved these changes
Nov 8, 2026
chr-hertel
added
2026-07-28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #616 and #636, for the first limit under an event loop: a server that sends the PSR-7 body itself, like
amphp/http-serverorreact/http, never got the SSE frames the transport echoes, so the examples answered501.CallbackStream::chunks()hands such a server the SSE text of a2026-07-28response. On an empty chunk it waits on its loop, and dropping the generator ends the stream, so the handler sends nothing more. The PHP-FPM output stays the same, byte for byte.StatelessProtocol::listen()no longer sleeps itself, its consumer paces it: a[BC Break]for code readingStatelessProtocol::handle()streams directly.InMemoryNotificationBusso thatsubscriptions/listencarries something. Handshake-era streams still get501, and the Inspector negotiates that era, so the interop tests open asubscriptions/listenstream directly.