Skip to content

[Docs] Bring the CORS defaults in http.md in line with CorsMiddleware - #590

Merged
chr-hertel merged 1 commit into
modelcontextprotocol:mainfrom
chr-hertel:docs-cors-default-headers
Oct 14, 2026
Merged

chr-hertel merged 1 commit into
modelcontextprotocol:mainfrom
chr-hertel:docs-cors-default-headers

Conversation

@chr-hertel

Copy link
Copy Markdown
Member

#576 added Mcp-Method, Mcp-Name and Mcp-Param-* to the CorsMiddleware defaults, but docs/run/http.md still lists the old defaults and tells browser clients to add these headers themselves.

  • Add the three headers to the documented allowedHeaders default
  • Replace the outdated hint with how a *-suffixed entry works

Fixes chr-hertel#77

🤖 Generated with Claude Code

@chr-hertel
chr-hertel requested a review from Nyholm as a code owner October 13, 2026 22:33
@chr-hertel chr-hertel added this to the 0.9.0 milestone Oct 13, 2026
@chr-hertel chr-hertel added documentation Improvements or additions to documentation Server Issues & PRs related to the Server component labels Oct 13, 2026
@chr-hertel
chr-hertel requested a balanced review from Copilot October 13, 2026 22:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation accurately reflects the middleware defaults and tested prefix-matching behavior.

0 open findings

What changed in this PR

Updates HTTP documentation to match CorsMiddleware defaults and wildcard-prefix behavior.

Changes:

  • Documents the added MCP request headers.
  • Explains *-suffixed header prefix matching.
File Description
docs/​run/​http.md Aligns documented CORS defaults and behavior with the implementation.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chr-hertel
chr-hertel merged commit 4f6d0e8 into modelcontextprotocol:main Oct 14, 2026
28 checks passed
@chr-hertel
chr-hertel deleted the docs-cors-default-headers branch October 14, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Server Issues & PRs related to the Server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Server] CorsMiddleware default headers block browser clients on 2026-07-28

2 participants