Skip to content

[Docs] Bring the docs back in sync with the code - #566

Merged
chr-hertel merged 9 commits into
modelcontextprotocol:mainfrom
chr-hertel:docs-sync-with-code
Oct 12, 2026
Merged

chr-hertel merged 9 commits into
modelcontextprotocol:mainfrom
chr-hertel:docs-sync-with-code

Conversation

@chr-hertel

Copy link
Copy Markdown
Member
  • Describe the client's server/discover probe and handshake fallback now that it defaults to 2026-07-28
  • Fix wrong claims across handlers, events, transports, subscriptions, schemas and examples
  • Document setSchemaValidator(), argument validation, getServerCapabilities(), HttpTransport::getSessionId(), client exceptions, custom extensions and the full builder method table
  • Fix CONTRIBUTING (missing BC list, dead CLAUDE.md link, interop prerequisite), ROADMAP and the 0.7.1/0.8.1 CHANGELOG sections
  • Fix ClientLogger ignoring the requested log level on 2026-07-28 requests

🤖 Generated with Claude Code

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The session-resumption example passes a nullable session ID as an HTTP header value.

1 open finding
What changed in this PR

Aligns documentation and examples with current protocol behavior while fixing modern-era client log filtering.

Changes:

  • Applies requested log levels to ClientLogger on 2026-07-28.
  • Updates protocol, transport, handler, schema, and client documentation.
  • Corrects examples, contribution guidance, roadmap, and changelog history.
File Description
tests/​Unit/​Server/​Stateless/​StatelessProtocolTest.php Tests modern ClientLogger filtering.
src/​Server/​Stateless/​StatelessProtocol.php Stores request log level in session.
src/​Server/​Builder.php Corrects notification bus documentation.
ROADMAP.md Marks resource-server authorization complete.
README.md Updates dependencies and documentation links.
examples/​server/​README.md Clarifies example logging.
examples/​server/​oauth-microsoft/​.env.dist Removes obsolete environment template.
examples/​server/​env-variables/​server.php Corrects example path.
examples/​server/​elicitation/​server.php Corrects documentation reference.
examples/​client/​stateless_lifecycle_client.php Demonstrates disabling handshake fallback.
examples/​client/​README.md Updates modern-client behavior.
examples/​client/​http_client_communication.php Removes obsolete concurrency guidance.
docs/​servers/​tools.md Corrects naming and structured-output behavior.
docs/​servers/​schemas.md Documents generation and validation.
docs/​servers/​resources.md Documents resource-not-found handling.
docs/​servers/​resource-templates.md Uses the resource-specific exception.
docs/​servers/​registration.md Corrects registration APIs and validation.
docs/​servers/​prompts.md Expands supported prompt return values.
docs/​servers/​completions.md Clarifies provider discovery and registration.
docs/​sdk-tier.md Updates conformance gap references.
docs/​run/​subscriptions.md Clarifies era-specific notification delivery.
docs/​run/​stdio.md Documents limits and protocol support.
docs/​run/​sessions.md Adds HTTP session-store guidance.
docs/​run/​server-builder.md Expands the builder method reference.
docs/​run/​protocol-eras.md Corrects routing and transport behavior.
docs/​run/​index.md Distinguishes stateless transport usage.
docs/​run/​http.md Expands HTTP middleware documentation.
docs/​run/​framework-integration.md Consolidates session guidance.
docs/​run/​authorization.md Adds resource documentation metadata.
docs/​protocol-versions.md Clarifies client and notification behavior.
docs/​index.md Corrects server exit handling.
docs/​handlers/​input-required.md Documents state and unsupported operations.
docs/​handlers/​index.md Uses a cross-version elicitation example.
docs/​handlers/​client-communication.md Corrects metadata and capability documentation.
docs/​get-started/​installation.md Expands optional dependency guidance.
docs/​get-started/​index.md Clarifies complete code examples.
docs/​examples.md Synchronizes the example catalog.
docs/​client/​transports.md Documents failures and session IDs.
docs/​client/​server-requests.md Updates modern request handling examples.
docs/​client/​index.md Corrects default protocol behavior.
docs/​client/​errors.md Expands client exception documentation.
docs/​client/​connecting.md Documents negotiation and capabilities.
docs/​client/​capabilities.md Handles non-text prompt content.
docs/​advanced/​index.md Clarifies advanced feature scope.
docs/​advanced/​extensions.md Documents custom extensions.
docs/​advanced/​events.md Clarifies event dispatch behavior.
docs/​advanced/​custom-handlers.md Documents handler limitations.
CONTRIBUTING.md Corrects setup, testing, and BC guidance.
CHANGELOG.md Restores releases and records the fix.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/client/transports.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Connection documentation misstates pinned negotiation and exposes stale server metadata behavior across reconnects.

2 open findings
1 resolved since last review

🧠 Review effort: Balanced

Comment thread docs/client/connecting.md
Comment on lines +254 to +258
// (null on 2026-07-28 when the server/discover result has no serverInfo)
$serverInfo = $client->getServerInfo();
echo "Server: {$serverInfo->name} v{$serverInfo->version}\n";
echo "Server: {$serverInfo?->name} v{$serverInfo?->version}\n";

// Get the capabilities the server declared
Comment thread docs/client/connecting.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The connection guide incorrectly guarantees that server capabilities are known even when modern discovery omits them.

2 open findings
1 resolved since last review

🧠 Review effort: Balanced

Comment thread docs/client/connecting.md
Comment on lines +5 to +6
version. After that, the server's capabilities are known and you can use its tools, resources
and prompts.
@chr-hertel
chr-hertel merged commit cf60040 into modelcontextprotocol:main Oct 12, 2026
28 checks passed
@chr-hertel
chr-hertel deleted the docs-sync-with-code branch October 12, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants