Align safe-integer-range wording with server/tools.mdx - #3208
Closed
MarkovianProtocol wants to merge 1 commit into
Closed
MarkovianProtocol wants to merge 1 commit into
MarkovianProtocol wants to merge 1 commit into
Conversation
Both files state the same x-mcp-header constraint, with two different justifications. tools.mdx was revised to the IEEE754 wording during review of modelcontextprotocol#2772; streamable-http.mdx was not. The bound is unchanged. Co-Authored-By: Claude Opus 5 <[email protected]>
Author
|
Closing this — withdrawing on our side, not for any technical reason. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server/tools.mdxandbasic/transports/streamable-http.mdxstate the samex-mcp-headerconstraint with two different justifications:tools.mdx— "the safe range for integers represented using IEEE754 double-precision floating point numbers (−253+1 to 253−1)"streamable-http.mdx— "the safe range for JavaScript (−253+1 to 253−1)"The IEEE754 wording came out of review on #2772, where @pja-ant noted that "even in languages that have native integers, sometimes JSON parsing libraries will parse to
doubleby default" and @mikekistler replied "Fair point. I will revise." That revision landed intools.mdxonly, and both files shipped in2026-07-28with the difference still present.This applies the same wording in
draft. The bound itself is unchanged.Noticed while reading modelcontextprotocol/conformance#445.