Add roots listing capability - #29
Merged
Merged
Conversation
jspahrsummers
approved these changes
Nov 4, 2024
jspahrsummers
left a comment
jspahrsummers
left a comment
Member
There was a problem hiding this comment.
Conceptually this seems fine to me, but please can you:
- Add more documentation—in particular, explaining the "roots" concept in more detail
- Clarifying that only
file://URIs are currently supported
dsp-ant
force-pushed
the
davidsp/list-roots
branch
from
November 4, 2024 14:33
ef198c1 to
4e60160
Compare
Add support for listing root URIs from clients, with optional change notifications. This allows servers to discover available client-side roots through a new roots/list request and notifications/roots/list_changed notification. Roots are meant to inform the client about files and folders to operate in.
dsp-ant
force-pushed
the
davidsp/list-roots
branch
from
November 4, 2024 14:57
4e60160 to
5f60c57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for listing root URIs from clients, with optional change notifications.
This allows servers to discover available client-side roots through a new
roots/list request and notifications/roots/list_changed notification.
Roots are meant to inform the client about files and folders to operate in.