Skip to content

fix: use execFileSync for prettier to avoid shell injection (CodeQL #21) #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcp-commander merged 1 commit into from
Apr 9, 2026
Merged

fix: use execFileSync for prettier to avoid shell injection (CodeQL #21) #2546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/render-seps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@

import * as fs from "fs";
import * as path from "path";
import { execSync } from "child_process";
import { execFileSync } from "child_process";

const npx = process.platform === "win32" ? "npx.cmd" : "npx";

const SEPS_DIR = path.join(__dirname, "..", "seps");
const DOCS_SEPS_DIR = path.join(__dirname, "..", "docs", "seps");
Expand Down Expand Up @@ -392,7 +394,7 @@ async function main() {
// Format MDX files with Prettier
const mdxTempFiles = tempFiles.filter(({ temp }) => temp.endsWith(".mdx")).map(({ temp }) => temp);
if (mdxTempFiles.length > 0) {
execSync(`npx prettier --write ${mdxTempFiles.join(" ")}`, { stdio: "pipe" });
execFileSync(npx, ["prettier", "--write", ...mdxTempFiles], { stdio: "pipe" });
}

// Compare formatted temp files with existing files
Expand Down Expand Up @@ -432,7 +434,7 @@ async function main() {
.map(({ path: p }) => path.relative(process.cwd(), p));
if (filesToFormat.length > 0) {
console.log("\nFormatting generated files with Prettier...");
execSync(`npx prettier --write ${filesToFormat.join(" ")}`, { stdio: "inherit" });
execFileSync(npx, ["prettier", "--write", ...filesToFormat], { stdio: "inherit" });
}

console.log("\nSEP documentation generated successfully!");
Expand Down
Loading