Fix duplicate SSE plugin installation in Ktor application helpers (#1079) - #1092
Open
soulkeykim wants to merge 1 commit into
Open
soulkeykim wants to merge 1 commit into
soulkeykim wants to merge 1 commit into
Conversation
soulkeykim
marked this pull request as ready for review
October 1, 2026 23:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1079.
Summary
Application.mcpand the sharedApplication.mcpStreamableHttpsetup.The production change is one import and two guards. There are no public API changes.
Testing
Using JDK 21.0.12.1 and the repository's Gradle 9.8.0 wrapper:
./gradlew :kotlin-sdk-server:jvmTest --tests '*KtorExtensionsTest'ran 8 cases: the 3 duplicate-install regressions failed withDuplicatePluginException, and the other 5 passed../gradlew :kotlin-sdk-server:jvmTestpassed all 167 server JVM tests, with no failures or skips../gradlew :kotlin-sdk-server:ktlintCheckpassed../gradlew :kotlin-sdk-server:detektpassed, includingdetektMainJvm.git diff --checkpassed.Full
:kotlin-sdk-server:checkKotlinAbicould not complete in the validation environment: Kotlin/Native's MinGW dependency download (msys2-mingw-w64-x86_64-2.tar.gz) was blocked by an HTTP 403 from the environment proxy. The ABI result is therefore unverified and should be checked in CI. JS and Wasm compilation completed during the first ABI attempt; non-JVM runtime tests and the full repository build were not run.