fix: resolve resource leaks in transport session and httpclient#868
Open
noxymon wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: resolve resource leaks in transport session and httpclient#868noxymon wants to merge 1 commit intomodelcontextprotocol:mainfrom
noxymon wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #547 critical resource leaks in the MCP Java SDK. It ensures that internal connections are always disposed of during session shutdown and that HttpClient instances (and their associated SelectorManager threads) are properly
closed. Key changes include refactoring DefaultMcpTransportSession and HTTP-based transports to use doFinally for guaranteed cleanup, and implementing a robust HttpClient closure utility in Utils.
Motivation and Context
This change resolves two significant issues:
HttpClient-xxxx-SelectorManager threads, eventually leading to memory exhaustion and application instability.
By utilizing Project Reactor's doFinally operator, we guarantee that resource cleanup occurs regardless of whether the shutdown process completes successfully, errors out, or is cancelled.
How Has This Been Tested?
Breaking Changes
None. These are internal stability improvements that do not alter the public API or behavior beyond ensuring resource reclamation.
Types of changes
Checklist
Additional context
The implementation of Utils.closeHttpClient includes a reflection-based fallback to access the internal stop() method for JDK versions prior to 21 (where HttpClient does not implement AutoCloseable). This ensures that thread leakage is prevented
across the entire range of supported Java versions. For JDK 21+, it utilizes the native close() method.