Skip to content

Improve unit test isolation. - #28

Merged
sjpfenninger merged 2 commits into
feature-performancefrom
feature-performance-fixes
Sep 24, 2026
Merged

sjpfenninger merged 2 commits into
feature-performancefrom
feature-performance-fixes

Conversation

@irm-codebase

@irm-codebase irm-codebase commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

Better isolates the unit test environment and location to avoid future conflicts with the integration test and due to dependency divergence.

Summary of changes in this pull request

  • test-unit and module are now 'married' during solving and lockfile generation, while keeping test-unit dependencies out of the module conda lockfiles.
  • unit tests have their own placement to avoid conftest.py conflicts between regular integration tests and unit tests.
  • Should also fix the Windows tests failure (cause was the deletion of an open file, which is not allowed on that OS).

Reviewer checklist

  • There are no pip dependencies in the module's environment files (workflow/envs/).
  • All rules use pathvars (e.g., <results>) in their inputs and outputs.
  • The integration test-suite is successful, including:
    • pre-commit.ci tests pass.
    • tests pass for all relevant OS configurations (linux, osx, windows).
  • Module documentation is up-to-date, including:
    • INTERFACE.yaml mentions all relevant pathvars and wildcards.
    • README.md describes how to use the module and has the necessary citations.

@irm-codebase irm-codebase mentioned this pull request Sep 14, 2026
8 tasks
Root cause was attempt to delete open file.

---

Co-authored-by: Codex <[email protected]>
@sjpfenninger
sjpfenninger merged commit 181943e into feature-performance Sep 24, 2026
1 check passed
@irm-codebase
irm-codebase deleted the feature-performance-fixes branch September 24, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants