#390 - Kong Discovery JWT expiration - #394
Merged
vladyslav-fenchak merged 16 commits intoApr 21, 2022
Merged
Conversation
…discovery-jwt-expiration Restyle #390 - Kong Discovery JWT expiration
This was
linked to
issues
Apr 19, 2022
Closed
garciparedes
suggested changes
Apr 21, 2022
garciparedes
left a comment
garciparedes
left a comment
Contributor
There was a problem hiding this comment.
Hi @vladyslav-fenchak, awesome changes! Could you resolve the comments I left around the PR?
| ) -> str: | ||
| payload = {"iss": key, "exp": exp, "nbf": nbf} | ||
|
|
||
| current = datetime.now(tz=utc) |
Contributor
There was a problem hiding this comment.
You can use minos.common.current_datetime instead of directly generating a timezone based datetime by your own.
…discovery-jwt-expiration Restyle #390 - Kong Discovery JWT expiration
garciparedes
approved these changes
Apr 21, 2022
garciparedes
left a comment
garciparedes
left a comment
Contributor
There was a problem hiding this comment.
Hi @vladyslav-fenchak, now it LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.