added recursive json serialization for entities#626
Merged
SilasKenneth merged 2 commits intomicrosoftgraph:devfrom Nov 8, 2021
Merged
added recursive json serialization for entities#626SilasKenneth merged 2 commits intomicrosoftgraph:devfrom
SilasKenneth merged 2 commits intomicrosoftgraph:devfrom
Conversation
Dakoni4400
requested review from
MIchaelMainer,
Ndiritu,
SilasKenneth,
andrueastman,
baywet,
ddyett,
nikithauc,
ramsessanchez and
zengin
as code owners
Member
|
Hi @Dakoni4400 |
baywet
approved these changes
Nov 8, 2021
baywet
approved these changes
Nov 8, 2021
Member
|
thanks for updating the test files. |
Author
|
Thanks for the quick support @baywet |
SilasKenneth
approved these changes
Nov 8, 2021
Member
SilasKenneth
left a comment
SilasKenneth
left a comment
There was a problem hiding this comment.
Thank you so much @Dakoni4400 for putting this together, we really appreciate your effort to make improvements to the PHP SDK. Will be creating a PR with these changes shortly.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When calling jsonSerialize() on PHP entities if the properties of that entity contain any other entities it does not serialize them properly. This pull request adds in the recursive serialization for entities.
Microsoft Reviewers: Open in CodeFlow