This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Repository navigation
Deploy to Clue and Deploy Command Pallete Refactoring - #279
Merged
Merged
Conversation
Vandy Liu (vandyliu)
requested review from
Andrea Mah (andreamah) and
Kevin Nguyen (xnkevinnguyen)
March 26, 2020 23:10
Contributor
|
Regarding the commands, It's definitely a good improvement and will reduce the number of commands overall. |
Contributor
|
Agreed with the formal name, Adafruit Clue, Adafruit Circuit Playground Express, BBC micro:bit |
Contributor
|
Sounds great! I agree with Kevin. |
David Serafimov (nasadigital)
approved these changes
Mar 30, 2020
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Andrea Mah (@andreamah) Kevin Nguyen (@xnkevinnguyen)
CLUE, have it asAdafruit CLUECPX, have it asAdafruit Circuit Playground ExpressorCircuit Playground ExpressType of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check