This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Repository navigation
Restructure micropython libs and adding print statements to functions in the microbit library that we will not implement in the simulator - #257
Merged
Vandy Liu (vandyliu) merged 17 commits intoMar 16, 2020
Conversation
Vandy Liu (vandyliu)
requested review from
Andrea Mah (andreamah) and
Kevin Nguyen (xnkevinnguyen)
March 9, 2020 23:52
David Serafimov (nasadigital)
approved these changes
Mar 10, 2020
Andrea Mah (andreamah)
approved these changes
Mar 10, 2020
Andrea Mah (andreamah)
left a comment
Contributor
There was a problem hiding this comment.
Yay! Awesome 😁
Kevin Nguyen (xnkevinnguyen)
suggested changes
Mar 11, 2020
Kevin Nguyen (xnkevinnguyen)
approved these changes
Mar 13, 2020
Vandy Liu (vandyliu)
requested review from
Andrea Mah (andreamah),
David Serafimov (nasadigital) and
Kevin Nguyen (xnkevinnguyen)
March 13, 2020 21:21
David Serafimov (nasadigital)
approved these changes
Mar 16, 2020
Andrea Mah (andreamah)
approved these changes
Mar 16, 2020
Andrea Mah (andreamah)
left a comment
Contributor
There was a problem hiding this comment.
(❁´◡`❁) good to go!!
Vandy Liu (vandyliu)
deleted the
users/t-vali/unsupported-python-modules
branch
March 16, 2020 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE TEST IT OUT
Description:
AB#34028
src/micropython{function_name} on line {line_number} in {user_file_name} is not implemented in the simulator but it will work on the actual device!Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Tested in the simulator with:
Checklist:
npm run formatand passes the checks innpm run check