This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Repository navigation
changed package import name from cpx to cp - #173
Merged
Andrea Mah (andreamah) merged 2 commits intoJan 22, 2020
Merged
Conversation
Contributor
Author
|
It seems that CircuitPython's standard import statement changed a few months ago. It now can automatically detect the CP board type (Bluefruit vs Express). See: adafruit/Adafruit_CircuitPython_CircuitPlayground@cfa0053#diff-83e362785431178a0efc45ce23e99323 |
Andrea Mah (andreamah)
requested review from
Jonathan Wang (jonathanwangg),
Vandy Liu (vandyliu) and
Kevin Nguyen (xnkevinnguyen)
and removed request for
Jonathan Wang (jonathanwangg)
January 22, 2020 00:18
Contributor
|
Nice fix and nice find! |
Vandy Liu (vandyliu)
approved these changes
Jan 22, 2020
Isa (isadorasophia)
approved these changes
Jan 22, 2020
Isa (isadorasophia)
left a comment
Contributor
There was a problem hiding this comment.
That was simple enough 😮 Cool!
Mark Schramm (markAtMicrosoft)
approved these changes
Jan 22, 2020
Vandy Liu (vandyliu)
deleted the
users/t-anmah/cpx-library-name-change
branch
January 23, 2020 03:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Allowed for both imports as:
from adafruit_circuitplayground import cpand
from adafruit_circuitplayground.express import cpxThis was requested since the first import statement above is how most tutorials present the import statement.
Type of change
Please delete options that are not relevant.
Limitations:
Testing:
Checklist: