Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Fix lack of null check on currentActiveFile - #136

Merged
Luke Slevinsky (LukeSlev) merged 1 commit into
devfrom
users/t-luslev/fix-no-active-file-run
Aug 21, 2019
Merged

Fix lack of null check on currentActiveFile#136
Luke Slevinsky (LukeSlev) merged 1 commit into
devfrom
users/t-luslev/fix-no-active-file-run

Conversation

@LukeSlev

@LukeSlev Luke Slevinsky (LukeSlev) commented Aug 21, 2019

Copy link
Copy Markdown
Member

Description:

This PR is a bug fix for if you try to run no file

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing:

  • open the simulator with no files open and press play, should not blow up

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@LukeSlev Luke Slevinsky (LukeSlev) changed the title Rix lack of null check on currentActiveFile Fix lack of null check on currentActiveFile Aug 21, 2019
FMounz
FMounz approved these changes Aug 21, 2019
View reviewed changes

@FMounz FMounz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@jonathanwangg
Jonathan Wang (jonathanwangg) deleted the users/t-luslev/fix-no-active-file-run branch August 26, 2019 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonathanwangg Jonathan Wang (jonathanwangg) Awaiting requested review from jonathanwangg
@Christellah Christellah Awaiting requested review from Christellah
@abmahdy Ahmed Mahdy (abmahdy) Awaiting requested review from abmahdy abmahdy is a code owner
@adclements Andrew Clements (adclements) Awaiting requested review from adclements adclements is a code owner
@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner
2 more reviewers
@markAtMicrosoft Mark Schramm (markAtMicrosoft) markAtMicrosoft approved these changes
@FMounz FMounz FMounz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LukeSlev @markAtMicrosoft @FMounz