Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Adding telemetry for the new features - #112

Merged
FMounz merged 38 commits into
devfrom
users/t-famoun/appinsight-telemetry
Aug 20, 2019
Merged

FMounz merged 38 commits into
devfrom
users/t-famoun/appinsight-telemetry

Conversation

@FMounz

@FMounz FMounz commented Aug 13, 2019 •

Copy link
Copy Markdown
Contributor

Description:

This PR adds Telemetry for the new features. The usage of the sensors is tracked as well as the non implemented functions that the user might try to use.
To do so Application Insights for python has been used.

Type of change

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Make sure telemetry is enabled in vscode. Use on of the sensor available and make sure that a new event is registered on Azure.
  • Try using one of the unimplemented functions of the API. Make sure a new telemetry event is registered on Azure

Telemetry added:
'TAPPED': "API.TAPPED",
'PLAY_FILE': "API.PLAY.FILE",
'PLAY_TONE': "API.PLAY.TONE",
'START_TONE': "API.START.TONE",
'STOP_TONE': "API.STOP.TONE",
'DETECT_TAPS': "API.DETECT.TAPS",
'ADJUST_THRESHOLD': "API.ADJUST.THRESHOLD",
'RED_LED': "API.RED.LED",
'PIXELS': "API.PIXELS"
SIMULATOR_TEMPERATURE_SENSOR = "SIMULATOR.TEMPERATURE",
SIMULATOR_LIGHT_SENSOR = " SIMULATOR.LIGHT",
SIMULATOR_MOTION_SENSOR = "SIMULATOR.MOTION",
SIMULATOR_SHAKE = "SIMULATOR.SHAKE",
SIMULATOR_CAPACITIVE_TOUCH = "SIMULATOR.CAPACITIVE.TOUCH",

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@FMounz FMounz reopened this Aug 13, 2019

@LukeSlev Luke Slevinsky (LukeSlev) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to look at here!

Comment thread src/adafruit_circuitplayground/express.py Outdated
Comment thread src/adafruit_circuitplayground/express.py Outdated
Comment thread src/adafruit_circuitplayground/express.py Outdated
Comment thread src/adafruit_circuitplayground/express.py Outdated
Comment thread src/adafruit_circuitplayground/pixel.py Outdated
Comment thread src/adafruit_circuitplayground/express.py Outdated
Comment thread src/constants.ts Outdated
Comment thread src/extension.ts Outdated
Comment thread src/view/components/Simulator.tsx Outdated
Comment thread src/constants.ts Outdated
@LukeSlev

Copy link
Copy Markdown
Member

FMounz conflicts again

@LukeSlev

Copy link
Copy Markdown
Member

FMounz conflicts again

@LukeSlev

Copy link
Copy Markdown
Member

FMounz conflicts

Comment thread src/adafruit_circuitplayground/express.py
@LukeSlev

Copy link
Copy Markdown
Member

Discussed offline we really only want to track feature usage per run not total times the method was called.

Comment thread src/adafruit_circuitplayground/utils.py Outdated
Comment thread src/adafruit_circuitplayground/utils.py Outdated
Comment thread src/adafruit_circuitplayground/utils.py Outdated

@LukeSlev Luke Slevinsky (LukeSlev) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FMounz
FMounz merged commit f9c0623 into dev Aug 20, 2019
@jonathanwangg
Jonathan Wang (jonathanwangg) deleted the users/t-famoun/appinsight-telemetry branch August 26, 2019 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants