This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Repository navigation
Add telemetry to run simulator commands - #110
Merged
Luke Slevinsky (LukeSlev) merged 3 commits intoAug 15, 2019
Merged
Conversation
Luke Slevinsky (LukeSlev)
requested review from
Ahmed Mahdy (abmahdy),
Andrew Clements (adclements),
Mark Schramm (markAtMicrosoft) and
smmatte
as code owners
August 13, 2019 01:39
…nt commands but look the same
| "menus": { | ||
| "commandPalette": [ | ||
| { | ||
| "command": "pacifica.runSimulatorEditorButton", |
Member
Author
There was a problem hiding this comment.
we don't want to expose the editor button command to the users via the command palette
Jonathan Wang (jonathanwangg)
approved these changes
Aug 14, 2019
Jonathan Wang (jonathanwangg)
left a comment
Jonathan Wang (jonathanwangg)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. We'll be able to differentiate which method people prefer to use to run their code! I tried it out and works as expected. Events are logged to Applications Insights correctly. Just some typo suggestions.
| COMMAND_OPEN_SIMULATOR = "COMMAND.OPEN.SIMULATOR", | ||
| COMMAND_RUN_SIMULATOR = "COMMAND.RUN.SIMULATOR", | ||
| COMMAND_RUN_SIMULATOR_BUTTON = "COMMAND.RUN.SIMULATOR_BUTTON", | ||
| COMMAND_RUN_PALLETTE = "COMMAND.RUN.PALLETTE", |
Contributor
There was a problem hiding this comment.
Typo: Palette should only have 1 "l".
Suggested change
| COMMAND_RUN_PALLETTE = "COMMAND.RUN.PALLETTE", | |
| COMMAND_RUN_PALETTE = "COMMAND.RUN.PALETTE", |
| () => { | ||
| telemetryAI.trackFeatureUsage(TelemetryEventName.COMMAND_RUN_EDITOR_ICON); | ||
| runSimulatorCommand(); | ||
| }) |
Contributor
There was a problem hiding this comment.
Missing semicolon.
Suggested change
| }) | |
| }); |
| const runSimulator: vscode.Disposable = vscode.commands.registerCommand( | ||
| "pacifica.runSimulator", | ||
| () => { | ||
| telemetryAI.trackFeatureUsage(TelemetryEventName.COMMAND_RUN_PALLETTE); |
Contributor
There was a problem hiding this comment.
Extra "l" in palette.
Suggested change
| telemetryAI.trackFeatureUsage(TelemetryEventName.COMMAND_RUN_PALLETTE); | |
| telemetryAI.trackFeatureUsage(TelemetryEventName.COMMAND_RUN_PALETTE); |
Ahmed Mahdy (abmahdy)
approved these changes
Aug 15, 2019
Jonathan Wang (jonathanwangg)
deleted the
users/t-luslev/run-simulator-telemetry
branch
August 26, 2019 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds telemetry unique telemetry events for the different run simulator methods
Type of change
Please delete options that are not relevant.
Testing:
Checklist: