Skip to content

Synchronize contents in multiple editors for same nb file#9886

Merged
DonJayamanne merged 14 commits intomicrosoft:ds/custom_editorfrom
DonJayamanne:sync3
Feb 5, 2020
Merged

Synchronize contents in multiple editors for same nb file#9886
DonJayamanne merged 14 commits intomicrosoft:ds/custom_editorfrom
DonJayamanne:sync3

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Feb 4, 2020 •
edited
Loading

For #9340
Note

  • This PR adds the infrastructure necessary to sync edits & the like across editors for the same file
  • Code has been commented out to ensure some remaining bits work properly
  • Waiting on some of the new changes from @rchiodo from his undo PR.

Remaining changes

  • Ensuring we do not end up in a crazy loop that will cause one editor to propagate changes to the other, then that one back to this & so on
  • Sync cell execution (currently creation of new cells isn't sync'ed across)
  • Find a bullet proof solution for syncing focused states (this messes up everything - we don't need this in syncing editors, but if required for live share, then we need to ensure focus states work correctly - depending on whether liveshare even needs such a feature?)

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 4, 2020
@DonJayamanne DonJayamanne marked this pull request as ready for review February 4, 2020 17:18
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 4, 2020 •
edited
Loading

Codecov Report

Merging #9886 into ds/custom_editor will decrease coverage by 0.01%.
The diff coverage is 25%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ds/custom_editor   #9886      +/-   ##
===================================================
- Coverage             60.62%   60.6%   -0.02%     
===================================================
  Files                   555     555              
  Lines                 29737   29748      +11     
  Branches               4482    4484       +2     
===================================================
+ Hits                  18027   18029       +2     
- Misses                10709   10718       +9     
  Partials               1001    1001
Impacted Files Coverage Δ
...ience/interactive-common/interactiveWindowTypes.ts 100% <100%> (ø) ⬆️
...ractive-common/interactiveWindowMessageListener.ts 17.02% <14.28%> (-0.48%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 5.79% <25%> (-0.03%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 87.5% <0%> (ø) ⬆️
src/client/linters/pydocstyle.ts 88.63% <0%> (ø) ⬆️
src/client/datascience/debugLocationTracker.ts 78.12% <0%> (ø) ⬆️
src/client/common/process/proc.ts 15.21% <0%> (ø) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bf2ea...d83dd70. Read the comment docs.

@DonJayamanne DonJayamanne requested review from DavidKutu, IanMatthewHuff and rchiodo and removed request for rchiodo February 4, 2020 19:02
rchiodo
rchiodo reviewed Feb 4, 2020
View reviewed changes
Comment thread src/client/datascience/interactive-common/syncrhonization.ts
rchiodo
rchiodo reviewed Feb 4, 2020
View reviewed changes
Comment thread src/client/datascience/interactive-common/types.ts Outdated
rchiodo
rchiodo reviewed Feb 4, 2020
View reviewed changes
Comment thread src/datascience-ui/native-editor/redux/reducers/effects.ts Outdated
rchiodo
rchiodo approved these changes Feb 4, 2020
View reviewed changes
Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

IanMatthewHuff
IanMatthewHuff reviewed Feb 4, 2020
View reviewed changes
Comment thread src/client/datascience/interactive-common/interactiveWindowTypes.ts Outdated
@DonJayamanne DonJayamanne reopened this Feb 5, 2020
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DonJayamanne DonJayamanne merged commit 7d22caa into microsoft:ds/custom_editor Feb 5, 2020
@DonJayamanne DonJayamanne deleted the sync3 branch February 5, 2020 17:42
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo