Remove root level flags used to track cell selection and focus#9874
Closed
DonJayamanne wants to merge 10 commits intomicrosoft:ds/custom_editorfrom
Closed
Remove root level flags used to track cell selection and focus#9874DonJayamanne wants to merge 10 commits intomicrosoft:ds/custom_editorfrom
DonJayamanne wants to merge 10 commits intomicrosoft:ds/custom_editorfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## ds/custom_editor #9874 +/- ##
===================================================
Coverage ? 60.62%
===================================================
Files ? 555
Lines ? 29737
Branches ? 4482
===================================================
Hits ? 18027
Misses ? 10709
Partials ? 1001
Continue to review full report at Codecov.
|
DonJayamanne
force-pushed
the
noRootLevelFlags
branch
from
55057d0 to
2f3f8b4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9340
To be merged after #9840
Basically I got rid of the root level state info that keeps track of the cell that's selected and focused.
This required us to keep the two in sync along with the state at the cell level.
When syncing information between multiple editors this got messy. removing this removes the issues where things could go out of sync, i.e. two ways to storing the same thing. Now we get selected information from the cells directly - single source of truth.