Repository navigation
Clean fs resources in the background - #9823
Merged
Don Jayamanne (DonJayamanne) merged 1 commit intoJan 29, 2020
Merged
Conversation
Don Jayamanne (DonJayamanne)
requested a review
from Eric Snow (ericsnowcurrently)
January 29, 2020 17:26
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #9823 +/- ##
==========================================
+ Coverage 60.88% 60.88% +<.01%
==========================================
Files 556 556
Lines 30041 30042 +1
Branches 4554 4554
==========================================
+ Hits 18291 18292 +1
Misses 10723 10723
Partials 1027 1027
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9800
#9800 (comment)
When we've detected that a directory is r/w, we can delete the temp file in the background without blocking the call to check if dir is readonly.