Repository navigation
Factor out FileSystemUtils - #9808
Merged
Eric Snow (ericsnowcurrently) merged 17 commits intoJan 30, 2020
Merged
Conversation
Eric Snow (ericsnowcurrently)
requested a review
from Karthik Nadig (karthiknadig)
January 28, 2020 22:39
Codecov Report
@@ Coverage Diff @@
## master #9808 +/- ##
==========================================
+ Coverage 60.87% 61.02% +0.15%
==========================================
Files 556 556
Lines 30043 30074 +31
Branches 4555 4556 +1
==========================================
+ Hits 18290 18354 +64
+ Misses 10726 10694 -32
+ Partials 1027 1026 -1
Continue to review full report at Codecov.
|
Karthik Nadig (karthiknadig)
approved these changes
Jan 29, 2020
Eric Snow (ericsnowcurrently)
force-pushed
the
fs-utils
branch
from
January 30, 2020 21:16
ef12e0a to
cf3abba
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #8995)
This is one of the last parts to be un-reverted for the FS changes.
Note that most of the PR is tests. The changes in fileSystem.ts are mostly just moving code around.