Repository navigation
Drop PlatformService as a dependency of FileSystem. - #9784
Merged
Eric Snow (ericsnowcurrently) merged 1 commit intoJan 27, 2020
Merged
Eric Snow (ericsnowcurrently) merged 1 commit into
Eric Snow (ericsnowcurrently) merged 1 commit into
Conversation
Eric Snow (ericsnowcurrently)
requested a review
from Kim-Adeline Miguel (kimadeline)
January 27, 2020 20:40
|
Kudos, SonarCloud Quality Gate passed!
|
|
Did you/Will you/Can you run CI tests on this PR? |
Codecov Report
@@ Coverage Diff @@
## master #9784 +/- ##
==========================================
- Coverage 60.88% 60.87% -0.01%
==========================================
Files 556 556
Lines 30000 29998 -2
Branches 4548 4548
==========================================
- Hits 18265 18261 -4
- Misses 10708 10710 +2
Partials 1027 1027
Continue to review full report at Codecov.
|
Author
|
Kim-Adeline Miguel (@kimadeline), yeah, I'll do that. It just takes soooo long and this PR has almost 0 risk. |
Kim-Adeline Miguel (kimadeline)
approved these changes
Jan 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #8995)
The dependency is unnecessary and adds complication to various places that FileSystem is used. Dropping it simplifies things going forward.