Repository navigation
Drop FileSystem.getRealPath(). - #9697
Merged
Eric Snow (ericsnowcurrently) merged 3 commits intoJan 21, 2020
Merged
Eric Snow (ericsnowcurrently) merged 3 commits into
Eric Snow (ericsnowcurrently) merged 3 commits into
Conversation
It hasn't been used for a year and a half.
Eric Snow (ericsnowcurrently)
requested a review
from Kim-Adeline Miguel (kimadeline)
January 21, 2020 19:27
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #9697 +/- ##
==========================================
+ Coverage 60.64% 60.79% +0.14%
==========================================
Files 547 550 +3
Lines 29541 29651 +110
Branches 4467 4485 +18
==========================================
+ Hits 17914 18025 +111
+ Misses 10629 10616 -13
- Partials 998 1010 +12
Continue to review full report at Codecov.
|
Kim-Adeline Miguel (kimadeline)
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #8995)
It hasn't been used for a year and a half.
[ ] Has a news entry file (remember to thank yourself!)[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.