Skip to content

Add helpers for identifying "system" errors. - #9615

Merged
Eric Snow (ericsnowcurrently) merged 3 commits into
microsoft:masterfrom
ericsnowcurrently:fs-errors
Jan 16, 2020
Merged

Add helpers for identifying "system" errors.#9615
Eric Snow (ericsnowcurrently) merged 3 commits into
microsoft:masterfrom
ericsnowcurrently:fs-errors

Conversation

@ericsnowcurrently

@ericsnowcurrently Eric Snow (ericsnowcurrently) commented Jan 15, 2020

Copy link
Copy Markdown

(for #8995)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [ ] Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@ericsnowcurrently Eric Snow (ericsnowcurrently) added the no-changelog No news entry required label Jan 15, 2020
@sonarqubecloud

sonarqubecloud Bot commented Jan 15, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io

Codecov (codecov-io) commented Jan 15, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9615 into master will decrease coverage by 0.45%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9615      +/-   ##
==========================================
- Coverage   60.94%   60.49%   -0.46%     
==========================================
  Files         530      545      +15     
  Lines       28628    29377     +749     
  Branches     4338     4446     +108     
==========================================
+ Hits        17448    17771     +323     
- Misses      10229    10621     +392     
- Partials      951      985      +34
Impacted Files Coverage Δ
src/client/common/platform/errors.ts 100% <100%> (ø)
src/client/linters/mypy.ts 38.46% <0%> (-49.04%) ⬇️
src/client/common/process/condaExecutionService.ts 70% <0%> (-30%) ⬇️
src/client/datascience/jupyter/jupyterVariables.ts 48.64% <0%> (-13.33%) ⬇️
...lient/datascience/jupyter/kernels/kernelService.ts 50.58% <0%> (-10.14%) ⬇️
src/client/common/process/pythonProcess.ts 92.3% <0%> (-4.19%) ⬇️
src/client/interpreter/activation/service.ts 84.93% <0%> (-2.77%) ⬇️
src/client/datascience/jupyter/notebookStarter.ts 69% <0%> (-2.55%) ⬇️
src/client/activation/activationService.ts 88.16% <0%> (-1.6%) ⬇️
...ce/interactive-window/interactiveWindowProvider.ts 13.68% <0%> (-1.44%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb4191b...f746339. Read the comment docs.

karrtikr
Kartik Raj (karrtikr) approved these changes Jan 16, 2020
View reviewed changes

@karrtikr Kartik Raj (karrtikr) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently
Eric Snow (ericsnowcurrently) merged commit fef6489 into microsoft:master Jan 16, 2020
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@karrtikr Kartik Raj (karrtikr) karrtikr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericsnowcurrently @codecov-io @karrtikr