Repository navigation
Factor out RawFileSystem. - #9499
Merged
Eric Snow (ericsnowcurrently) merged 15 commits intoJan 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9499 +/- ##
==========================================
- Coverage 60.79% 60.19% -0.61%
==========================================
Files 551 556 +5
Lines 29666 31842 +2176
Branches 4486 5138 +652
==========================================
+ Hits 18036 19167 +1131
- Misses 10620 11589 +969
- Partials 1010 1086 +76
Continue to review full report at Codecov.
|
Eric Snow (ericsnowcurrently)
force-pushed
the
fs-raw
branch
2 times, most recently
from
January 21, 2020 19:48
a0cc33c to
68762f5
Compare
Eric Snow (ericsnowcurrently)
requested a review
from Karthik Nadig (karthiknadig)
January 21, 2020 21:07
3 tasks done
Karthik Nadig (karthiknadig)
approved these changes
Jan 22, 2020
Eric Snow (ericsnowcurrently)
pushed a commit
that referenced
this pull request
Jan 22, 2020
(for #8895) This change helps simplify the changes in #9499.
Eric Snow (ericsnowcurrently)
force-pushed
the
fs-raw
branch
from
January 23, 2020 23:49
68762f5 to
aa09387
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #8995)
This separates the low-level filesystem operations from the high-level "fs utils". The move to the VS Code FS API can then happen strictly inside RawFileSystem. Also, this is part of what we reverted in #8970.
Note that the bulk of the changes are in test code. Also, of the non-test code, the changes are either just moving things around (from
FileSystemtoRawFileSystem), or adding the newRawFileSystemclass (andIRawFileSysteminterface).