Skip to content

Bypass conda service when creating daemons - #9454

Merged
Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:bypassConda
Jan 8, 2020
Merged

Bypass conda service when creating daemons#9454
Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:bypassConda

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Jan 8, 2020

Copy link
Copy Markdown

Related to #9444
(do not use conda service conda run when starting the daemon)

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Jan 8, 2020
@sonarqubecloud

sonarqubecloud Bot commented Jan 8, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

IanMatthewHuff
Ian Huff (IanMatthewHuff) requested changes Jan 8, 2020
View reviewed changes

@IanMatthewHuff Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

IanMatthewHuff
Ian Huff (IanMatthewHuff) approved these changes Jan 8, 2020
View reviewed changes

@IanMatthewHuff Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo

Rich Chiodo (rchiodo) commented Jan 8, 2020

Copy link
Copy Markdown

I'm a little nervous with this one. What bug is causing you to make this change? conda run is working for me on my machine.

@DonJayamanne

Don Jayamanne (DonJayamanne) commented Jan 8, 2020

Copy link
Copy Markdown
Author

I'm a little nervous with this one. What bug is causing you to make this change? conda run is working for me on my machine.

Today the daemon works using activated environmen variables. However if the daemon is busy we fall back to the regular python process. This will end up using conda run.
The new change ensures that it doesn't use conda run, but only uses activated environment variables.

@codecov-io

Codecov (codecov-io) commented Jan 8, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9454 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9454      +/-   ##
==========================================
+ Coverage   60.91%   60.91%   +<.01%     
==========================================
  Files         530      530              
  Lines       28650    28650              
  Branches     4344     4344              
==========================================
+ Hits        17451    17452       +1     
+ Misses      10246    10245       -1     
  Partials      953      953
Impacted Files Coverage Δ
src/client/datascience/jupyter/notebookStarter.ts 71.54% <ø> (ø) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f943f26...bde5a0b. Read the comment docs.

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit a734c63 into microsoft:master Jan 8, 2020
Don Jayamanne (DonJayamanne) added a commit that referenced this pull request Jan 8, 2020
@DonJayamanne
Bypass conda service when creating daemons (#9454)
bb92e98 
* Bypass conda run for DS code
Closed
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 16, 2020
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the bypassConda branch April 30, 2020 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff Ian Huff (IanMatthewHuff) IanMatthewHuff approved these changes
@rchiodo Rich Chiodo (rchiodo) rchiodo approved these changes
+1 more reviewer
@DavidKutu David Kutugata (DavidKutu) DavidKutu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DonJayamanne @rchiodo @codecov-io @IanMatthewHuff @DavidKutu