Skip to content

Skip a few platform-related tests for CI failures (for now). - #9354

Merged
Kartik Raj (karrtikr) merged 6 commits into
microsoft:masterfrom
ericsnowcurrently:fix-fs-ci
Jan 2, 2020
Merged

Kartik Raj (karrtikr) merged 6 commits into
microsoft:masterfrom
ericsnowcurrently:fix-fs-ci

Conversation

@ericsnowcurrently

Copy link
Copy Markdown

(for #8995)

This PR temporarily disables some failing functional tests (but only on the failing platforms). The tests were added in PR #9170. We will fix them ASAP, but in the meantime still have coverage on other platforms.

@ericsnowcurrently Eric Snow (ericsnowcurrently) added the no-changelog No news entry required label Jan 1, 2020
@codecov-io

Codecov (codecov-io) commented Jan 1, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #9354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #9354   +/-   ##
======================================
  Coverage    60.2%   60.2%           
======================================
  Files         544     544           
  Lines       28620   28620           
  Branches     4333    4333           
======================================
  Hits        17232   17232           
+ Misses      10460   10453    -7     
- Partials      928     935    +7
Impacted Files Coverage Δ
src/client/common/utils/version.ts 81.48% <0%> (ø) ⬆️
.../client/datascience/jupyter/jupyterConnectError.ts 75% <0%> (ø) ⬆️
src/client/datascience/cellFactory.ts 71.25% <0%> (ø) ⬆️
src/client/language/characters.ts 94.28% <0%> (ø) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (ø) ⬆️
src/client/constants.ts 80% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38122f3...cc5006f. Read the comment docs.

@ericsnowcurrently Eric Snow (ericsnowcurrently) changed the title Fix fs ci Skip a few platform-related tests for CI failures (for now). Jan 1, 2020
@ericsnowcurrently

Copy link
Copy Markdown
Author

Assuming this change looks good, feel free to merge this after reviewing. I'm out another week still.

@karrtikr
Kartik Raj (karrtikr) merged commit 4237a55 into microsoft:master Jan 2, 2020
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants