Repository navigation
Skip a few platform-related tests for CI failures (for now). - #9354
Merged
Kartik Raj (karrtikr) merged 6 commits intoJan 2, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9354 +/- ##
======================================
Coverage 60.2% 60.2%
======================================
Files 544 544
Lines 28620 28620
Branches 4333 4333
======================================
Hits 17232 17232
+ Misses 10460 10453 -7
- Partials 928 935 +7
Continue to review full report at Codecov.
|
Author
|
Assuming this change looks good, feel free to merge this after reviewing. I'm out another week still. |
Kartik Raj (karrtikr)
approved these changes
Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #8995)
This PR temporarily disables some failing functional tests (but only on the failing platforms). The tests were added in PR #9170. We will fix them ASAP, but in the meantime still have coverage on other platforms.