Repository navigation
Factor out path-related classes for better testing. - #9352
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9352 +/- ##
==========================================
+ Coverage 60.93% 60.95% +0.02%
==========================================
Files 529 530 +1
Lines 28580 28632 +52
Branches 4339 4338 -1
==========================================
+ Hits 17415 17454 +39
- Misses 10214 10227 +13
Partials 951 951
Continue to review full report at Codecov.
|
|
Can you please also manually run CI against this PR? |
|
Kartik Raj (@karrtikr) Will do. What motivated you to ask? (it's not a normal step) |
|
Your previous PR broke master when merged. When making large changes I'd recommend running CI against a PR. |
|
Agreed. The failing functional tests are tests that I added. 😄 I just hadn't run them on Windows and apparently that did not happen during PR validation. (and FWIW, the change wasn't that large; most of it was tests) |
ef6de2c to
0d0fabf
Compare
Kartik Raj (karrtikr)
left a comment
Kartik Raj (karrtikr)
left a comment
There was a problem hiding this comment.
If the CI has no failing tests for this PR, feel free to merge it.
|
I'm pretty sure those 2 failures are not due to this PR. I'll double-check tomorrow before merging. |
994334a to
f589160
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Yep, the Windows tests have been timing out on master and the OSX tests all passed when I re-ran CI. |
4 participants
(for #8995)
This adds back in some of the refactored code and high-level functional tests reverted in #8970. It also adds more tests and gets things ready for #8542 (where we will drop the pathutils module, etc.).