Skip to content

Register conda service to resolve DS functional tests - #9002

Merged
Rich Chiodo (rchiodo) merged 3 commits into
microsoft:masterfrom
DonJayamanne:fixDSCIUseCondaSvc
Dec 12, 2019
Merged

Register conda service to resolve DS functional tests#9002
Rich Chiodo (rchiodo) merged 3 commits into
microsoft:masterfrom
DonJayamanne:fixDSCIUseCondaSvc

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Dec 10, 2019

Copy link
Copy Markdown

No description provided.

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Dec 10, 2019
@codecov-io

Codecov (codecov-io) commented Dec 10, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9002 into master will decrease coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9002      +/-   ##
==========================================
- Coverage   57.92%   56.98%   -0.94%     
==========================================
  Files         530      550      +20     
  Lines       27658    28959    +1301     
  Branches     4188     4376     +188     
==========================================
+ Hits        16020    16502     +482     
- Misses      10750    11556     +806     
- Partials      888      901      +13
Impacted Files Coverage Δ
.../datascience/interactive-common/interactiveBase.ts 18.06% <0%> (-0.62%) ⬇️
src/client/datascience/jupyter/jupyterSession.ts 6.81% <0%> (-0.24%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 5.29% <0%> (-0.04%) ⬇️
src/client/common/utils/version.ts 81.48% <0%> (ø) ⬆️
.../client/datascience/jupyter/jupyterConnectError.ts 75% <0%> (ø) ⬆️
...ient/datascience/interactive-ipynb/nativeEditor.ts 53.84% <0%> (ø) ⬆️
src/client/datascience/cellFactory.ts 71.25% <0%> (ø) ⬆️
...ience/interactive-common/interactiveWindowTypes.ts 100% <0%> (ø) ⬆️
...atascience/jupyter/liveshare/guestJupyterServer.ts 11.94% <0%> (ø) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (ø) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43665c...dc7cb73. Read the comment docs.

IanMatthewHuff
Ian Huff (IanMatthewHuff) approved these changes Dec 11, 2019
View reviewed changes

@IanMatthewHuff Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo

Rich Chiodo (rchiodo) commented Dec 12, 2019

Copy link
Copy Markdown

I'm going to submit this to see if the nightly flakey will pass

@rchiodo
Rich Chiodo (rchiodo) merged commit b37f277 into microsoft:master Dec 12, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the fixDSCIUseCondaSvc branch December 17, 2019 17:28
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff Ian Huff (IanMatthewHuff) IanMatthewHuff approved these changes
@rchiodo Rich Chiodo (rchiodo) rchiodo approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @rchiodo @IanMatthewHuff